Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23730 )
Change subject: IMPALA-14566: Add euclidean_distance and cosine_similarity functions for ARRAY<FLOAT> ...................................................................... Patch Set 8: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23730/8/be/src/exprs/scalar-expr-evaluator.cc File be/src/exprs/scalar-expr-evaluator.cc: http://gerrit.cloudera.org:8080/#/c/23730/8/be/src/exprs/scalar-expr-evaluator.cc@476 PS8, Line 476: VectorFunctions::EuclideanDistance(nullptr, CollectionVal::null(), CollectionVal::null()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23730/8/be/src/exprs/scalar-expr-evaluator.cc@477 PS8, Line 477: VectorFunctions::CosineSimilarity(nullptr, CollectionVal::null(), CollectionVal::null()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23730/8/be/src/exprs/vector-functions.h File be/src/exprs/vector-functions.h: http://gerrit.cloudera.org:8080/#/c/23730/8/be/src/exprs/vector-functions.h@63 PS8, Line 63: /// Validates: non-NULL vectors, non-empty arrays, matching lengths, and no NULL elements. line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23730/8/common/function-registry/gen_builtins_catalog.py File common/function-registry/gen_builtins_catalog.py: http://gerrit.cloudera.org:8080/#/c/23730/8/common/function-registry/gen_builtins_catalog.py@88 PS8, Line 88: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23730/8/common/function-registry/gen_builtins_catalog.py@88 PS8, Line 88: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/23730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id305acc87530d5d0e53613fe8df9a631ea4e1080 Gerrit-Change-Number: 23730 Gerrit-PatchSet: 8 Gerrit-Owner: Raghav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Raghav Jindal <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 18:06:05 +0000 Gerrit-HasComments: Yes
