Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23487 )

Change subject: IMPALA-14131: Add flag to configure the default value of 
'impala.disableHmsSync'
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23487/6/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/23487/6/tests/custom_cluster/test_events_custom_configs.py@1850
PS6, Line 1850:       self.run_stmt_in_hive(
> I thought the other way would happen, describe table fetches only metadata
Currently describe leads to fetching everythinh in catalogd, while the 
coordinator will only load basic file metadata (no per partition filelisting)


http://gerrit.cloudera.org:8080/#/c/23487/8/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/23487/8/tests/custom_cluster/test_events_custom_configs.py@1847
PS8, Line 1847:       events_skipped_before = 
EventProcessorUtils.get_int_metric('events-skipped', 0)
              :       EventProcessorUtils.wait_for_event_processing(self)
It seem clearer to me to get events_skipped_before after waiting for event 
processor?



--
To view, visit http://gerrit.cloudera.org:8080/23487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee617aed48575502d9cf5cf2cbea6ec897d6839
Gerrit-Change-Number: 23487
Gerrit-PatchSet: 8
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 04 Dec 2025 10:41:03 +0000
Gerrit-HasComments: Yes

Reply via email to