Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23487 )
Change subject: IMPALA-14131: Add flag to configure the default value of 'impala.disableHmsSync' ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23487/9/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23487/9/tests/custom_cluster/test_events_custom_configs.py@1855 PS9, Line 1855: # verify that events are not skipped and data is synced nit: this is stale when 'skip_events' is not 0 http://gerrit.cloudera.org:8080/#/c/23487/9/tests/custom_cluster/test_events_custom_configs.py@1857 PS9, Line 1857: no Let's print 'skip_events' here. http://gerrit.cloudera.org:8080/#/c/23487/9/tests/custom_cluster/test_events_custom_configs.py@1885 PS9, Line 1885: _check_insert_events(tbl1, 4, skip_events=1, part='partition(year=2024)') nit: can we also test tbl2 here? -- To view, visit http://gerrit.cloudera.org:8080/23487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee617aed48575502d9cf5cf2cbea6ec897d6839 Gerrit-Change-Number: 23487 Gerrit-PatchSet: 9 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 09:21:55 +0000 Gerrit-HasComments: Yes
