Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23487 )
Change subject: IMPALA-14131: Add flag to configure the default value of 'impala.disableHmsSync' ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/23487/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23487/5/be/src/catalog/catalog-server.cc@323 PS5, Line 323: all objects > We always process database events. https://github.com/apache/impala/blob/ma Can you update the flag description to reflect this? E.g. all objects (with the exception of databases). http://gerrit.cloudera.org:8080/#/c/23487/5/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23487/5/tests/custom_cluster/test_events_custom_configs.py@1848 PS5, Line 1848: # load tables in cache > I think you meant 'impala.disableHmsSync' is set to 'true' for the database >I think you meant 'impala.disableHmsSync' is set to 'true' oops, yes http://gerrit.cloudera.org:8080/#/c/23487/5/tests/custom_cluster/test_events_custom_configs.py@1849 PS5, Line 1849: self.client.execute("invalidate metadata {}".format(tbl)) : self.client.execute("describe {}".format(tbl)) : self.run_stmt_in_hive( : """ALTER DATABASE {} SET DBPROPERTIES ('impala.disableHmsSync'='false')""" : .format(unique_database)) : events_skipped_before = EventProcessorUtils.get_int_metric('events-skipped', 0) : EventProcessorUtils.wait_for_event_processing(self) : # modify data externally : self.run_stmt_in_hive( > I had to invalidate the tables because they are not loaded in the cache. I I am not forcing this, but my idea for the function was to use it at multiple places (case 1, 3) http://gerrit.cloudera.org:8080/#/c/23487/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23487/6/tests/custom_cluster/test_events_custom_configs.py@1850 PS6, Line 1850: self.client.execute("describe {}".format(tbl)) I think that DESCRIBE is not the ideal way to do this - this is something that we could optimize in the future to avoid loading files, which would make the test too easy to pass again. The table is small, so I don't see a reason against select *. -- To view, visit http://gerrit.cloudera.org:8080/23487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee617aed48575502d9cf5cf2cbea6ec897d6839 Gerrit-Change-Number: 23487 Gerrit-PatchSet: 6 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 21 Nov 2025 15:53:57 +0000 Gerrit-HasComments: Yes
