Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23699 )
Change subject: IMPALA-14536: Fix CONVERT TO ICEBERG to not throw exception on Iceberg tables ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23699/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23699/5/fe/src/main/java/org/apache/impala/service/Frontend.java@3034 PS5, Line 3034: if (analysisResult.isConvertTableToIcebergStmt()) { : result.setResult_set_metadata(new TResultSetMetadata( : Collections.singletonList(new TColumn("summary", Type.STRING.toThrift())))); : result.setNoop_result( : Collections.singletonList("Table has already been migrated.")); : } Instead of having this if stmt here, we could have a method in StatementBase: getNoopSummary() -- To view, visit http://gerrit.cloudera.org:8080/23699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41ecbfd350d38e4e3fd7b813a4fc27211d828f73 Gerrit-Change-Number: 23699 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 01 Dec 2025 16:57:01 +0000 Gerrit-HasComments: Yes
