Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23699 )
Change subject: IMPALA-14536: Fix CONVERT TO ICEBERG to not throw exception on Iceberg tables ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23699/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23699/2//COMMIT_MSG@7 PS2, Line 7: Fix CONVERT TO ICEBERG to not throw exception on Iceberg tabl > Phrasing it this way makes the assumption that this is the problem that thi Done http://gerrit.cloudera.org:8080/#/c/23699/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23699/2/be/src/service/client-request-state.cc@2522 PS2, Line 2522: > nit: "has already been" Done http://gerrit.cloudera.org:8080/#/c/23699/2/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/23699/2/common/thrift/Frontend.thrift@654 PS2, Line 654: 13: optional bool noop > What about putting this field a level above, in TExecRequest? I created a new TStmtType to be more universal. -- To view, visit http://gerrit.cloudera.org:8080/23699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41ecbfd350d38e4e3fd7b813a4fc27211d828f73 Gerrit-Change-Number: 23699 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 26 Nov 2025 13:45:48 +0000 Gerrit-HasComments: Yes
