Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23699 )
Change subject: IMPALA-14536: Fix CONVERT TO ICEBERG to not throw exception on Iceberg tables ...................................................................... Patch Set 5: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/23699/5/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/23699/5/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@254 PS5, Line 254: public boolean isNoOp() { Oh, I see now. You're calling parsedStmt_.isNoOp() I think we should change this to return stmt_ != null ? stmt_.isNoOp() : false; There really isn't a reason to put this into the ParsedStatement interface since there are no plans for the Calcite planner to ever deal with this kind of statement anytime in the near future. -- To view, visit http://gerrit.cloudera.org:8080/23699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41ecbfd350d38e4e3fd7b813a4fc27211d828f73 Gerrit-Change-Number: 23699 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 14:01:09 +0000 Gerrit-HasComments: Yes
