Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 6: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/common.h File be/src/exprs/geo/common.h: http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/common.h@28 PS6, Line 28: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df669cbfaaf1edbfac0461acd1af45e12b81/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 line too long (168 > 90) http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/geospatial-functions-ir.cc File be/src/exprs/geo/geospatial-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/geospatial-functions-ir.cc@104 PS6, Line 104: // https://github.com/apache/hive/blob/9eeab40173479c74b6fbf6657c3472b81ce4efcd/ql/src/java/org/apache/hadoop/hive/ql/udf/esri/ST_EnvIntersects.java#L63 line too long (156 > 90) http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/shape-format.h File be/src/exprs/geo/shape-format.h: http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/shape-format.h@30 PS6, Line 30: // https://www.esri.com/content/dam/esrisites/sitecore-archive/Files/Pdfs/library/whitepapers/pdfs/shapefile.pdf line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/shape-format.h@36 PS6, Line 36: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df669cbfaaf1edbfac0461acd1af45e12b81/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L16 line too long (168 > 90) http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/shape-format.h@85 PS6, Line 85: // See https://github.com/Esri/geometry-api-java/blob/d9ed3598b72029c9ebde024e0e616933cff81db2/src/main/java/com/esri/core/geometry/ShapeType.java#L27 line too long (150 > 90) http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py@45 PS6, Line 45: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 25 Nov 2025 12:23:04 +0000 Gerrit-HasComments: Yes
