Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23699 )
Change subject: IMPALA-14536: CONVERT TO ICEBERG does not throw exception on Iceberg tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23699/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23699/2/be/src/service/client-request-state.cc@2522 PS2, Line 2522: has been already nit: "has already been" http://gerrit.cloudera.org:8080/#/c/23699/2/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/23699/2/common/thrift/Frontend.thrift@654 PS2, Line 654: 13: optional bool noop What about putting this field a level above, in TExecRequest? So that other operations can also use this flag if they are also NOOP/idempotent and that TConvertTableRequest does not have to be filled with dummy info in case of NOOP. -- To view, visit http://gerrit.cloudera.org:8080/23699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41ecbfd350d38e4e3fd7b813a4fc27211d828f73 Gerrit-Change-Number: 23699 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 21 Nov 2025 13:02:42 +0000 Gerrit-HasComments: Yes
