Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23518 )
Change subject: IMPALA-14480: Optional OpenTelemetry DCHECKs ...................................................................... Patch Set 7: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/23518/7/be/src/observe/otel-flags-trace.cc File be/src/observe/otel-flags-trace.cc: http://gerrit.cloudera.org:8080/#/c/23518/7/be/src/observe/otel-flags-trace.cc@68 PS7, Line 68: DEFINE_bool(otel_trace_exhaustive_dchecks, false, "Specifies whether or not to " I'd make this a DEFINE_bool_hidden. http://gerrit.cloudera.org:8080/#/c/23518/7/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/23518/7/be/src/observe/span-manager.cc@52 PS7, Line 52: #ifndef NDEBUG I assume this avoids a unused variable warning? http://gerrit.cloudera.org:8080/#/c/23518/7/be/src/observe/span-manager.cc@189 PS7, Line 189: if (FLAGS_otel_trace_exhaustive_dchecks) { An alternative would be to use DCHECK(FLAGS_otel_trace_exhaustive_dchecks && current_child_) However this also seems fine. http://gerrit.cloudera.org:8080/#/c/23518/7/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23518/7/tests/custom_cluster/test_otel_trace.py@36 PS7, Line 36: "--otel_trace_exhaustive_dchecks --otel_file_flush_interval_ms=500 " \ Is this going to continue to result in intermittent test failures? -- To view, visit http://gerrit.cloudera.org:8080/23518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6507f3f0e23ecf7c2bece9a6b6c2d86bfac1e57 Gerrit-Change-Number: 23518 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 25 Nov 2025 17:23:36 +0000 Gerrit-HasComments: Yes
