Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23518 )
Change subject: IMPALA-14480: Optional OpenTelemetry DCHECKs ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23518/4/be/src/observe/span-manager.h File be/src/observe/span-manager.h: http://gerrit.cloudera.org:8080/#/c/23518/4/be/src/observe/span-manager.h@71 PS4, Line 71: DCHECK failed nit: will fail? http://gerrit.cloudera.org:8080/#/c/23518/4/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/23518/4/be/src/observe/span-manager.cc@598 PS4, Line 598: #ifndef NDEBUG : if (FLAGS_otel_trace_exhaustive_dchecks) { : DCHECK(false) << "Cannot start a new Close child span while a Close child span " : "is already active."; : } : #endif Do you think it might be useful to have a helper macro or something in order to reduce the #ifndef NDEBUG blocks repetitiveness? -- To view, visit http://gerrit.cloudera.org:8080/23518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6507f3f0e23ecf7c2bece9a6b6c2d86bfac1e57 Gerrit-Change-Number: 23518 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 04:32:54 +0000 Gerrit-HasComments: Yes
