Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23518 )
Change subject: [WIP] IMPALA-14480: Optional OpenTelemetry DCHECKs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23518/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23518/2//COMMIT_MSG@7 PS2, Line 7: Optional OpenTelemetry DCHECKs > So, are these DCHECK hits are not a real issue in the first place? They are a real issue, but the consequences of them failing are not serious enough to interrupt query processing. For example, IMPALA-14457 is for tests that fail because the 'ReleasedAdmissionControlResources' span event was added while no child span was active. That is a situation we should figure out, but it will be tricky because of the multi-threaded nature of the code managing each query. Until the situation gets figured out, it doesn't make sense to fail the DCHECK for this tiny issue, but I want the DCHECKs available to debug this situation in the future. -- To view, visit http://gerrit.cloudera.org:8080/23518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6507f3f0e23ecf7c2bece9a6b6c2d86bfac1e57 Gerrit-Change-Number: 23518 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 18:01:47 +0000 Gerrit-HasComments: Yes
