Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23487 )
Change subject: IMPALA-14131: Add flag to configure the default value of 'impala.disableHmsSync' ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23487/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23487/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1263 PS5, Line 1263: disable hms sync nit: to be consistent with other logs like L1254, let's use "flag {}" with MetastoreEventPropertyKey.DISABLE_EVENT_HMS_SYNC.getKey(). http://gerrit.cloudera.org:8080/#/c/23487/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1264 PS5, Line 1264: disable_hms_sync_by_default nit: "global flag disable_hms_sync_by_default" -- To view, visit http://gerrit.cloudera.org:8080/23487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ee617aed48575502d9cf5cf2cbea6ec897d6839 Gerrit-Change-Number: 23487 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 01:13:10 +0000 Gerrit-HasComments: Yes
