Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23566/8/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/23566/8/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java@132 PS8, Line 132: isPartitionPrunedFilterConjunct > I was thinking about modifying this to accept non-deterministic functions. I believe the current design is cleaner: 1. HdfsPartitionPruner is designed for metadata-level filtering. It explicitly skips non-deterministic functions. Since we want to perform per-partition evaluation, adding this logic changes its core contract. 2. SELECT queries also use HdfsPartitionPruner and they skip non-deterministic functions as they are evaluated per-row in the backend. We will have to add another check specifying if the pruning is attempted by SELECT or SHOW PARTITIONS. 3. The current design keeps partition pruning(planning layer) separate from SHOW PARTITIONS logic(analysis layer) Would you still prefer moving it to the pruner? I can do so, but wanted to explain why I kept it separate. -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 09:33:18 +0000 Gerrit-HasComments: Yes
