Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/23566/7/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23566/7/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@168 PS7, Line 168: show_column_minmax_stats_ = > nit: The following new code makes the analyze() method too long now (>100 l Done http://gerrit.cloudera.org:8080/#/c/23566/7/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@231 PS7, Line 231: HdfsPartitionPruner pruner = new HdfsPartitionPruner(tableRef.getDesc()); > HdfsPartitionPruner could skip some expressions in partition prunning and r 1. Ive changed the script now to take care of the conjuncts left out by prunePartitions. 2. From my analysis, its always non-deterministic conjuncts which are left out like rand(), now(). 3. Neither HdfsPartitionPruner.prunePartitions() nor HdfsPartitionFilter.getMatchingPartitionIds() evaluate them. 4. If we have unevaluated conjuncts, then we use the method in the new class PartitionPredicateEvaluator.evaluateForPartition() which evaluates the residual predicates against each partition sequentially(as asked by Quanlong) instead of constant folding. 5. The new method uses support from BE to evaluate the expr. http://gerrit.cloudera.org:8080/#/c/23566/7/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23566/7/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@608 PS7, Line 608: Stats(). > Use Optional or @Nullable annotation here. Done -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 18:19:44 +0000 Gerrit-HasComments: Yes
