Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/23566/8/fe/src/main/java/org/apache/impala/analysis/PartitionPredicateEvaluator.java File fe/src/main/java/org/apache/impala/analysis/PartitionPredicateEvaluator.java: http://gerrit.cloudera.org:8080/#/c/23566/8/fe/src/main/java/org/apache/impala/analysis/PartitionPredicateEvaluator.java@77 PS8, Line 77: > No, I mean we don't need seeding here to make rand() returns really random Done, the only downside will be that rand() will not work as the rand() in SELECT but as you said this is acceptable http://gerrit.cloudera.org:8080/#/c/23566/8/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/23566/8/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java@132 PS8, Line 132: (it.hasNext()) { > 1. changing the callsite codes is pretty simple. Just adding a new boolean Thanks for the advice, Ive added a new bool evalAllFuncs in prunePartitions() and simplified the code. http://gerrit.cloudera.org:8080/#/c/23566/9/testdata/workloads/functional-query/queries/QueryTest/show-stats.test File testdata/workloads/functional-query/queries/QueryTest/show-stats.test: http://gerrit.cloudera.org:8080/#/c/23566/9/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@397 PS9, Line 397: > This is misleading since it's not a non-deterministic predicate. Maybe the Thanks for pointing this out, this was coming from HdfsPartitionFilter. I've added a new condition that throws analysis exception when aggregate functions are passed. Im not sure about the feasibility of adding support for aggregate functions in SHOW PARTITIONS as they'll have to be processed on metadata unlike on row-data as done by SELECT. -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 10 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 27 Nov 2025 05:19:35 +0000 Gerrit-HasComments: Yes
