Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 1: (3 comments) Thanks Michael for the change, this will help make the build flow much faster. Added some minor comments. http://gerrit.cloudera.org:8080/#/c/23572/1/README-build.md File README-build.md: http://gerrit.cloudera.org:8080/#/c/23572/1/README-build.md@a64 PS1, Line 64: Are there any cases where we might still wanna use GOLD linker? Should we keep it temporarily for backward compat? http://gerrit.cloudera.org:8080/#/c/23572/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/23572/1/bin/impala-config.sh@1175 PS1, Line 1175: export IMPALA_LINK_THREADS=${IMPALA_LINK_THREADS-$((IMPALA_BUILD_THREADS < 2 ? 1 : IMPALA_BUILD_THREADS / 2))} > Tempted to just require 4GB of memory minimum and get rid of the corner cas Can we add a comment here similar to the commit message? http://gerrit.cloudera.org:8080/#/c/23572/1/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/23572/1/buildall.sh@83 PS1, Line 83: # Default to ninja if available as it has better concurrency support for linking. > This might be too magical. Our Jenkins environments assume they have 'make' It'd be good to have -ninja option -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 29 Oct 2025 09:04:36 +0000 Gerrit-HasComments: Yes
