Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@220 PS8, Line 220: // Need to disableResultSpooling if spoolResults_ is set to false so that : // the query option 'spool_query_results' is set to false. : disableResultSpooling(queryOptions); > > I suppose the one thing I dislike about your suggestion is setting the qu Still makes me nervous that "computeResourceProfile" will always be the last place spool option can be disabled, but I can let that go. I'm not really happy about making the addition of disabling the query option in CalciteSingleNodePlanner...I also have to do it in QueryStmt if I want to add that Precondition check. But I'll go ahead and do it and file a Jira as well as a disclaimer that I disliked doing it :) -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 15:02:49 +0000 Gerrit-HasComments: Yes
