Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23562 )

Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results
......................................................................


Patch Set 7:

(1 comment)

Ran test_calcite_planner.py on patch set 7 and Impalad crash.

F20251112 10:25:43.856554 76771 spillable-row-batch-queue.cc:42] 
484ce78cd7a1ad3f:30742bab00000000] Check failed: 
resource_profile_.spillable_buffer_size > 0 (0 vs. 0)                           
                                                             
Minidump in thread [76771]exec-finstance 
(finst:484ce78cd7a1ad3f:30742bab00000000) running query 
484ce78cd7a1ad3f:30742bab00000000, fragment instance 
484ce78cd7a1ad3f:30742bab00000000                                               
                                          
Wrote minidump to 
/tmp/minidumps/impalad/dcb47bd6-00df-46e2-bed9d091-809fc6c5.dmp

http://gerrit.cloudera.org:8080/#/c/23562/7/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java
File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java:

http://gerrit.cloudera.org:8080/#/c/23562/7/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@229
PS7, Line 229: mutateSpoolResultsToFalse
"disableResultSpooling" sounds more straightforward.



--
To view, visit http://gerrit.cloudera.org:8080/23562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f
Gerrit-Change-Number: 23562
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Wed, 12 Nov 2025 18:38:31 +0000
Gerrit-HasComments: Yes

Reply via email to