Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/23562/7/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/7/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@229 PS7, Line 229: ass and the query option. > Done Done http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@82 PS8, Line 82: public void computeProcessingCost(TQueryOptions queryOptions) { Please add precondition in the beginning. Preconditions.checkState(spoolResults_ == queryOptions.isSpool_query_results()); http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@119 PS8, Line 119: public void computeResourceProfile(TQueryOptions queryOptions) { Please add precondition in the beginning. Preconditions.checkState(spoolResults_ == queryOptions.isSpool_query_results()); http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@220 PS8, Line 220: // Need to disableResultSpooling if spoolResults_ is set to false so that : // the query option 'spool_query_results' is set to false. : disableResultSpooling(queryOptions); This can be avoided if CalciteSingleNodePlanner.createDataSink() disable the option first? See: https://gerrit.cloudera.org/c/23562/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java#99 http://gerrit.cloudera.org:8080/#/c/23562/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/23562/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@98 PS8, Line 98: boolean spoolResults = : ctx_.getQueryOptions().isSpool_query_results() && returnsMoreThanOneRow_; If spoolResults == false (because returnsMoreThanOneRow_ == false), need to disable spooling option here. ctx_.getQueryOptions().setSpool_query_results(spoolResults); -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 12 Nov 2025 20:50:35 +0000 Gerrit-HasComments: Yes
