Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23382/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23382/7//COMMIT_MSG@34 PS7, Line 34: Added @Nullable annotations on CatalogServiceCatalog methods that can : return null. Fixed some null check warnings that shows up afterwards. Apologies if this is too much, but it does reveal some issues that worth to fix along. http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3109 PS5, Line 3109: List<String> dbNames = > Actually, I think it is better to move the getDb lookup after waitOngoingMe Done -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 06 Sep 2025 02:22:41 +0000 Gerrit-HasComments: Yes
