Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java File fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java: http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java@179 PS5, Line 179: protected Pair<String, Future<PrefetchedDatabaseObjects>> peekFetchingDb() { > I think we can relax this as well. It just uses fetchingDbs_. Done http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3109 PS5, Line 3109: Db db = getDb(oldTableName.getDb_name()); > nit: Can we use WriteLockAndLookupDb here? This one call waitOngoingMetadataFetch(List<String> dbNames) that has slightly different semantic than waitOngoingMetadataFetch(String dbName). The former ensure that all dbNames are never under invalidation in single sweep (never await for any invalidation in between). So it is better to let this remain unchanged. -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 06 Sep 2025 01:05:49 +0000 Gerrit-HasComments: Yes
