Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23382 )
Change subject: IMPALA-14400: Fix deadlock in CatalogServiceCatalog.getDbProperty() ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java File fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java: http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogResetManager.java@179 PS5, Line 179: Preconditions.checkState(threadIsHoldingWriteLock()); I think we can relax this as well. It just uses fetchingDbs_. http://gerrit.cloudera.org:8080/#/c/23382/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1501 PS4, Line 1501: // catalog state. : resetManager_.waitOngoingMetadataFetch(dbName_); : } : return dbCache_.get > Patch set 5 ensure that waitInitialResetCompletion() is safe to call. Catal Sorry that I just realized waitInitialResetCompletion() is called on line 1492. So my concern is not a problem. http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23382/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3109 PS5, Line 3109: Db db = getDb(oldTableName.getDb_name()); nit: Can we use WriteLockAndLookupDb here? -- To view, visit http://gerrit.cloudera.org:8080/23382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a Gerrit-Change-Number: 23382 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 06 Sep 2025 00:46:13 +0000 Gerrit-HasComments: Yes
