Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23365 )
Change subject: IMPALA-14382: Fix Null Pointer Dereference ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23365/2/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23365/2/be/src/exec/base-sequence-scanner.cc@125 PS2, Line 125: VLOG_FILE << "Bytes read past scan range: " << (stream_ == nullptr ? 0 : : -stream_->bytes_left()); > I see nullptr check in HdfsTextScanner::Close() and HdfsTextScanner::Close( I'm not sure exactly why stream_ is nullptr. Since this is a log level 2 message in existing code, I don't want to deviate from the original intent of this log message and don't want to add any new log messages in case there is code some where relying on the "Bytes read past scan range" and "Average block size" messages being one after the other. I did realize that a default of -1 is incorrect. The bytes read past scan is always reported as a negative number. Thus, 144 bytes read will be reported as -144. This means -1 is reporting that a single byte was read past the scan range which is incorrect. I updated the log message to use 0 as the default since an unopened stream cannot have read any bytes past its end. -- To view, visit http://gerrit.cloudera.org:8080/23365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91660aa84407c17ffb7cd3c721d4f3f0a844d61d Gerrit-Change-Number: 23365 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 19:25:22 +0000 Gerrit-HasComments: Yes
