Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23365 )

Change subject: IMPALA-14382: Fix Null Pointer Dereference
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23365/2/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/23365/2/tests/run-tests.py@48
PS2, Line 48: build
> I've been using VSCode and never see this created. It also not checked into
Oh interesting.  When I remove the tests/build directory and reload VSCode, the 
directory is re-created.  It may be because I have "tests" as a top-level 
directory in my workspace.

I would like to leave this as running EE tests fails each time for me.  I 
updated tests/.gitignore to exclude the entire build directory.  There is 
already an entry that seems to have been an attempt to exclude the build 
directory:  
https://github.com/apache/impala/blob/843de44788758ab00694bc456e0d92608a8a4c60/tests/.gitignore#L2



--
To view, visit http://gerrit.cloudera.org:8080/23365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91660aa84407c17ffb7cd3c721d4f3f0a844d61d
Gerrit-Change-Number: 23365
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:34:22 +0000
Gerrit-HasComments: Yes

Reply via email to