Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23365 )

Change subject: IMPALA-14382: Fix Null Pointer Dereference
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23365/2/be/src/exec/base-sequence-scanner.cc
File be/src/exec/base-sequence-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/23365/2/be/src/exec/base-sequence-scanner.cc@125
PS2, Line 125:   VLOG_FILE << "Bytes read past scan range: " << (stream_ == 
nullptr ? -1 :
             :       -stream_->bytes_left());
Can you turn on the log level 2 and find out why stream_ is nullptr?

Open should initialize it
https://github.com/apache/impala/blob/843de44788758ab00694bc456e0d92608a8a4c60/be/src/exec/hdfs-scanner.cc#L98
There are only two other callsite that write to stream_: 
BaseSequenceScanner::Close() and HdfsParquetScanner::Open().

Does it mean there is a sequence scanner that Close() before Open()?


http://gerrit.cloudera.org:8080/#/c/23365/2/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/23365/2/tests/run-tests.py@48
PS2, Line 48: build
I've been using VSCode and never see this created. It also not checked into 
Apache Impala repo.
Can this be removed / ignored?



--
To view, visit http://gerrit.cloudera.org:8080/23365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91660aa84407c17ffb7cd3c721d4f3f0a844d61d
Gerrit-Change-Number: 23365
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:38:27 +0000
Gerrit-HasComments: Yes

Reply via email to