Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23342 )
Change subject: IMPALA-13125: Fix pairwise test vector generation ...................................................................... IMPALA-13125: Fix pairwise test vector generation Replaced allpairspy with a homemade pair finder that seems to find a somewhat less optimal (larger) covering vector set but works reliably with filters. For details see tests/common/test_vector.py Also fixes a few test issues uncovered. Some fixes are copied from https://gerrit.cloudera.org/#/c/23319/ Added the possibility of shuffling vectors to get a different test set (env var IMPALA_TEST_VECTOR_SEED). By default the algorithm is deterministic so the test set won't change between runs (similarly to allpairspy). Added a new constraint to test only a single compression per file format in some tests to reduce the number of new vectors. EE + custom_cluster test count in exhaustive runs: before patch: ~11000 after patch: ~16000 without compression constraint: ~17000 Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Reviewed-on: http://gerrit.cloudera.org:8080/23342 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M testdata/bin/generate-test-vectors.py M testdata/workloads/functional-query/queries/QueryTest/inline-view.test M testdata/workloads/functional-query/queries/QueryTest/sort-complex.test M testdata/workloads/functional-query/queries/QueryTest/top-n-complex.test M tests/common/test_dimensions.py M tests/common/test_vector.py M tests/query_test/test_date_queries.py M tests/query_test/test_decimal_queries.py M tests/query_test/test_queries.py M tests/util/workload_management.py 10 files changed, 141 insertions(+), 30 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Gerrit-Change-Number: 23342 Gerrit-PatchSet: 12 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
