Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23342 )
Change subject: IMPALA-13125: Fix pairwise test vector generation ...................................................................... Patch Set 10: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/23342/7/testdata/bin/generate-test-vectors.py File testdata/bin/generate-test-vectors.py: http://gerrit.cloudera.org:8080/#/c/23342/7/testdata/bin/generate-test-vectors.py@54 PS7, Line 54: # TODO IMPALA-13125 turned out to be not completely reliably - this script may also miss > yes, this script is probably not correct, but I don't even know if anyone u Maybe we could open a separate Jira for it? Also if this algorithm/file is removed, we could remove allpairspy from requirements.txt. -- To view, visit http://gerrit.cloudera.org:8080/23342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Gerrit-Change-Number: 23342 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 28 Aug 2025 08:39:55 +0000 Gerrit-HasComments: Yes
