Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23342 )
Change subject: IMPALA-13125: Fix pairwise test vector generation ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/23342/7/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/23342/7/tests/common/test_vector.py@320 PS7, Line 320: vector > Nit: 'vectors'? Done http://gerrit.cloudera.org:8080/#/c/23342/7/tests/common/test_vector.py@324 PS7, Line 324: in the result > Nit: this is not incorrect but could cause a misunderstanding because there tried to clarify it http://gerrit.cloudera.org:8080/#/c/23342/7/tests/common/test_vector.py@334 PS7, Line 334: t = (i, x, j, y) > Instead of this, you could do: Done http://gerrit.cloudera.org:8080/#/c/23342/7/tests/common/test_vector.py@343 PS7, Line 343: for j, y in enumerate(v[i+1:], i+1): : t = (i, x, j, y) : pairs_covered.add(t) : return remaining : > Could we store the tuples near L335 instead, to save another iteration? I am not sure if that would help - if there are a large number of input vectors it is very likely that most of them will be rejected based on cnt and won't reach the second iteration http://gerrit.cloudera.org:8080/#/c/23342/7/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/23342/7/tests/query_test/test_queries.py@128 PS7, Line 128: # set timestamp options to get consistent results for both format. > This is the same as L171-175. Do you think it's worth extracting into a fun not sure - I am actually concerned about why is this needed at all, but I didn't want to investigate it in the current patch -- To view, visit http://gerrit.cloudera.org:8080/23342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Gerrit-Change-Number: 23342 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 17:55:56 +0000 Gerrit-HasComments: Yes
