Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23319 )
Change subject: IMPALA-14333: Run impala-py.test using Python3 ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@42 PS5, Line 42: python2 impala-shell when IMPALA_USE_PYTHON3_TESTS=true. The reason is > Nit: extra blank line Done http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@45 PS5, Line 45: > Are we going to need separate builds to test impala-shell with the tests ru Personally, I rather move away from python2 totally. There are only few test that still cover Python2 shell today (calls create_impala_shell_executable_dimension()): tests/custom_cluster/test_client_ssl.py tests/custom_cluster/test_ipv6.py tests/query_test/test_date_queries.py tests/shell/test_shell_commandline.py tests/shell/test_shell_commandline_kerberos_auth.py tests/shell/test_shell_interactive.py But I suspect only tests/shell/test_shell_commandline.py has breakage due to UTF-8 tests. http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@59 PS5, Line 59: > Why did these tests work when run on Python 2 but break when run on Python I suspect some custom cluster test unknowingly start HiveServer2 manually (see CustomClusterTestSuite._start_hive_service()). Not sure why things change after Pyton3 switch. On the other hand, I see in run-all.sh that only TARGET_FILESYSTEM=hdfs should have HiveServer2 by default. https://github.com/apache/impala/blob/23a14a2/testdata/bin/run-all.sh#L72 -- To view, visit http://gerrit.cloudera.org:8080/23319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4 Gerrit-Change-Number: 23319 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 21:39:18 +0000 Gerrit-HasComments: Yes
