Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23319 )

Change subject: IMPALA-14333: Run impala-py.test using Python3
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23319/4/tests/custom_cluster/test_saml2_sso.py
File tests/custom_cluster/test_saml2_sso.py:

http://gerrit.cloudera.org:8080/#/c/23319/4/tests/custom_cluster/test_saml2_sso.py@220
PS4, Line 220:     authn_resp = self._generate_authn_response(request_id, 
attributes_xml)
             :     encoded_authn_resp = 
base64.urlsafe_b64encode(authn_resp.encode('utf-8'))
             :     body = (b"SAMLResponse=" + encoded_authn_resp + 
b"&RelayState="
             :             + encode_if_needed(relay_state))
> This way works in both python2 and python3:
Done



--
To view, visit http://gerrit.cloudera.org:8080/23319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4
Gerrit-Change-Number: 23319
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 22 Aug 2025 16:50:55 +0000
Gerrit-HasComments: Yes

Reply via email to