Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23319 )
Change subject: IMPALA-14333: [part 1] Make all pytest compatible with Python3 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23319/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23319/3//COMMIT_MSG@63 PS3, Line 63: python2 impala-shell > When I start this, Python3 pytest + Python2 shell test combo shows breakage These are the failing one: shell/test_shell_commandline.py::TestImpalaShell::()::test_international_characters shell/test_shell_commandline.py::TestImpalaShell::()::test_output_file_utf8 shell/test_shell_commandline.py::TestImpalaShell::()::test_binary_as_string shell/test_shell_commandline.py::TestImpalaShell::()::test_binary_display shell/test_shell_commandline.py::TestImpalaShell::()::test_utf8_decoding_error_handling shell/test_shell_commandline.py::TestImpalaShell::()::test_international_characters_profile shell/test_shell_commandline.py::TestImpalaShell::()::test_international_characters_prettyprint_tabs shell/test_shell_commandline.py::TestImpalaShell::()::test_international_characters Stacktrace is like this in some of those: E AssertionError: Cmd ['-B', '-q', "select '?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,?, ?, ?, ?, ?, ?,?, ?, ?, ?, ?, ?, ?, ?, ?'"] was expected to succeed: /home/rsuminto/workspace/imp ala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/option_parser.py:423: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal E if '--live_progress' in sys.argv and '--disable_live_progress' in sys.argv: E /home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/option_parser.py:427: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal E if '--strict_hs2_protocol' in sys.argv: E /home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/option_parser.py:433: UnicodeWarning: Unicode equal comparison failed to convert both argu ments to Unicode - interpreting them as being unequal E if '--verbose' in sys.argv and '--quiet' in sys.argv: E Starting Impala Shell with no authentication using Python 2.7.18 E Warning: live_progress only applies to interactive shell sessions, and is being skipped for now. E Opened TCP connection to localhost:21050 E Connected to localhost:21050 E Server version: impalad version 5.0.0-SNAPSHOT DEBUG (build 644e8df61e6c5324ff5e1406982f0a9bfa952c9c) E Traceback (most recent call last): E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/bin/impala-shell", line 8, in <module> E sys.exit(impala_shell_main()) E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 2480, in impala_shell_main E if execute_queries_non_interactive_mode(options, query_options): E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 2130, in execute_queries_non_interactive_mode E and shell.execute_query_list(queries)) E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 1908, in execute_query_list E if self.onecmd(q) is CmdStatus.ERROR: E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 829, in onecmd E return func(arg) E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 1311, in do_select E return self._execute_stmt(query_str, print_web_link=True) E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 1466, in _execute_stmt E self._print_if_verbose("Query: %s" % query_str) E File "/home/rsuminto/workspace/impala/shell/build/python2_venv/local/lib/python2.7/site-packages/impala_shell/impala_shell.py", line 1218, in _print_if_verbose E print(message, file=file_descriptor) E UnicodeEncodeError: 'ascii' codec can't encode character u'\u0410' in position 15: ordinal not in range(128) -- To view, visit http://gerrit.cloudera.org:8080/23319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4 Gerrit-Change-Number: 23319 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 14:26:48 +0000 Gerrit-HasComments: Yes
