Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23113 )
Change subject: IMPALA-13267: Display number of partitions for Iceberg tables (WIP) ...................................................................... Patch Set 3: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23113/3/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS3: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@251 PS3, Line 251: aggInfo_, dataFilesWithoutDeletes_, getIceTable().getContentFileStore().getPartitions(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@607 PS3, Line 607: //predicate pushdown with no time travel: can use partitionMap from filestore, no addition line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@638 PS3, Line 638: Pair<IcebergFileDescriptor, Boolean> delFileDesc = getFileDescriptor(delFile, fileStore); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@827 PS3, Line 827: TIcebergPartition partition = IcebergUtil.createIcebergPartitionInfo(getIceTable().getIcebergApiTable(), cf); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@836 PS3, Line 836: // If the partition is not in any of the maps above, put it in the oldPartitionMap. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@845 PS3, Line 845: IcebergUtil.createIcebergMetadata(getIceTable().getIcebergApiTable(), cf, partitionId)); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1064 PS3, Line 1064: public static TIcebergPartition createIcebergPartitionInfo(Table iceApiTbl, ContentFile cf) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1090 PS3, Line 1090: public static FbFileMetadata createIcebergMetadata(Table iceApiTbl, ContentFile cf, int partId) { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/23113/3/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@353 PS3, Line 353: oldFds, hostIndex, iceFiles, new HashMap<>(), requiresDataFilesInTableLocation, newFilesThreshold); line too long (107 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2f654bc6c9bdf9cfafc27b38b5ca2f7b6b4872 Gerrit-Change-Number: 23113 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 25 Jul 2025 12:37:41 +0000 Gerrit-HasComments: Yes
