Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/22901/9/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22901/9/tests/common/custom_cluster_test_suite.py@590 PS9, Line 590: prefferable nit: preferable http://gerrit.cloudera.org:8080/#/c/22901/9/tests/common/custom_cluster_test_suite.py@591 PS9, Line 591: global PREVIOUS_CMD_STR Is it possible to somehow evade using global here? Maybe a different singleton object could store this state. If it's not feasible to implement alternatively, consider this comment irrelevant. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 9 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 30 May 2025 13:44:51 +0000 Gerrit-HasComments: Yes
