Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22901/5//COMMIT_MSG@19 PS5, Line 19: 'with_args' decorator. NOTE: there might be more tests like that : revealed after running the tests in different order resulting in test : failures. > I agree. This is probably not ideal, but still worth to have. Agree, do you mean a comment in code about this or something else? http://gerrit.cloudera.org:8080/#/c/22901/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22901/7//COMMIT_MSG@14 PS7, Line 14: 'start-impala-cluster.py' has been run and skips the restarting if the > This feels like a cute hack that's kind of opaque to test writers. I can se Yeah, occasional failures may appear, although I wouldn't expect much. Especially when running tests in different order than established. As an option we can think of a global Cluster test key, e.g. '--reuse_running_clusters'. http://gerrit.cloudera.org:8080/#/c/22901/7//COMMIT_MSG@17 PS7, Line 17: Some tests however do require restart due to the specific metrics being > These could possibly also be addressed by saving a baseline at the beginnin As an option, yes. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 16:21:01 +0000 Gerrit-HasComments: Yes
