Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 9: (2 comments) @Riza, Yes, that's one of the failing scenarios. For now I've identified failing tests experimentally and fixed them with 'force_restart=True'. Do you have an idea how to fix this particular scenario additionally or we'are good? Otherwise, I've improved the logic to avoid restarting when '_start_impala_cluster' is called on cluster setup stage only, but not for regular '_start_impala_cluster' calls from within the tests as part of test logic. Latest jenkins in exhaustive mode shows no failures and no dump file reports. In summary we have 110 restarts saving attemps, 101 of which successful. 36 tests are excluded via 'force_restart'. Not much gain in itself but as discussed with Csaba offline, this might come handy in the future when we want to run custom cluster tests for many variants, which is currently constrained on 'CustomClusterTestSuite' level apparently due to the very cost of restarts. Also no visible time improvement on jenkins. http://gerrit.cloudera.org:8080/#/c/22901/9/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22901/9/tests/common/custom_cluster_test_suite.py@590 PS9, Line 590: prefferable > nit: preferable ack http://gerrit.cloudera.org:8080/#/c/22901/9/tests/common/custom_cluster_test_suite.py@591 PS9, Line 591: global PREVIOUS_CMD_STR > Is it possible to somehow evade using global here? Maybe a different single This is indeed a bit of hacking solution to speed up tests a little. We could think of wrapping it into a singleton, but we don't really need nothing extra here. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 9 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 01 Jun 2025 13:21:07 +0000 Gerrit-HasComments: Yes
