Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22330 )
Change subject: IMPALA-11980 (part 2): Fix absolute import issues for impala_shell ...................................................................... Patch Set 20: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22330/20/shell/impala_shell/shell_output.py File shell/impala_shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/22330/20/shell/impala_shell/shell_output.py@40 PS20, Line 40: t > flake8: E721 do not compare types, for exact checks use `is` / `is not`, fo This can be changed to if isinstance(str_to_convert, type(reference_str)): -- To view, visit http://gerrit.cloudera.org:8080/22330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica75a24fa6bcb78999b9b6f4f4356951b81c3124 Gerrit-Change-Number: 22330 Gerrit-PatchSet: 20 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 20 May 2025 19:36:27 +0000 Gerrit-HasComments: Yes
