Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22330 )
Change subject: IMPALA-11980 (part 2): Fix absolute import issues for impala_shell ...................................................................... Patch Set 18: (1 comment) > (1 comment) > > This change make sense to me. But I hope https://gerrit.cloudera.org/c/22845/ > stack can merge first to avoid difficult conflict resolution. I'll rebase this change after that stack lands, then I'm going to go ahead with it. http://gerrit.cloudera.org:8080/#/c/22330/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22330/18//COMMIT_MSG@22 PS18, Line 22: 3. This changes Thrift generation to put it directly in : $IMPALA_HOME/shell rather than $IMPALA_HOME/shell/gen-py. : This means that the generated Thrift code is rooted in : the same directory as the shell code. > This will move impala_build_version.py and impala_thrift_gen/ under shell/, Yes, that's mostly right. One small difference: impala_build_version.py is inside shell/impala_shell. So, it is: shell/impala_shell/ (including impala_build_version.py) shell/impala_thrift_gen/ shell/packaging/ Before this change, it was put in gen-py along with the thrift generated code. However, in the PyPi package, impala_build_version.py was always inside impala_shell, so this matches that behavior. -- To view, visit http://gerrit.cloudera.org:8080/22330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica75a24fa6bcb78999b9b6f4f4356951b81c3124 Gerrit-Change-Number: 22330 Gerrit-PatchSet: 18 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 22:28:33 +0000 Gerrit-HasComments: Yes
