Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22330 )
Change subject: IMPALA-11980 (part 2): Fix absolute import issues for impala_shell ...................................................................... Patch Set 19: (61 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/ImpalaHttpClient.py@49 PS19, Line 49: class ImpalaHttpClient(TTransportBase): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/ImpalaHttpClient.py@190 PS19, Line 190: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/ImpalaHttpClient.py@202 PS19, Line 202: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/ImpalaHttpClient.py@231 PS19, Line 231: h flake8: U100 Unused argument 'has_auth_cookie' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/TSSLSocketWithWildcardSAN.py File shell/impala_shell/TSSLSocketWithWildcardSAN.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/TSSLSocketWithWildcardSAN.py@31 PS19, Line 31: class TSSLSocketWithWildcardSAN(TSSLSocket.TSSLSocket): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@118 PS19, Line 118: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@228 PS19, Line 228: p flake8: U100 Unused argument 'protocol' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@274 PS19, Line 274: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@274 PS19, Line 274: s flake8: U100 Unused argument 'set_query_options' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@282 PS19, Line 282: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@315 PS19, Line 315: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@321 PS19, Line 321: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@325 PS19, Line 325: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@325 PS19, Line 325: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@329 PS19, Line 329: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@342 PS19, Line 342: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@350 PS19, Line 350: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@356 PS19, Line 356: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@362 PS19, Line 362: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@371 PS19, Line 371: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@380 PS19, Line 380: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@380 PS19, Line 380: w flake8: U100 Unused argument 'warn' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@852 PS19, Line 852: c flake8: U100 Unused argument 'column_value_getters' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@994 PS19, Line 994: q flake8: U100 Unused argument 'query_str' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@1238 PS19, Line 1238: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@1241 PS19, Line 1241: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@1244 PS19, Line 1244: l flake8: U100 Unused argument 'last_query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@1414 PS19, Line 1414: q flake8: U100 Unused argument 'query_handle' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_client.py@1531 PS19, Line 1531: ( flake8: E275 missing whitespace after keyword http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@363 PS19, Line 363: t flake8: U100 Unused argument 'type' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@363 PS19, Line 363: v flake8: U100 Unused argument 'value' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@363 PS19, Line 363: t flake8: U100 Unused argument 'traceback' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@714 PS19, Line 714: s flake8: U100 Unused argument 'signal' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@714 PS19, Line 714: f flake8: U100 Unused argument 'frame' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@822 PS19, Line 822: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@985 PS19, Line 985: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@1530 PS19, Line 1530: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@1649 PS19, Line 1649: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@1689 PS19, Line 1689: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@1849 PS19, Line 1849: a flake8: U100 Unused argument 'args' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@1854 PS19, Line 1854: i flake8: U100 Unused argument 'ignored' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@2287 PS19, Line 2287: e flake8: F841 local variable 'e' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/impala_shell.py@2330 PS19, Line 2330: i flake8: F401 'thrift.protocol.fastbinary' imported but unused http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/option_parser.py File shell/impala_shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/option_parser.py@272 PS19, Line 272: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/option_parser.py@273 PS19, Line 273: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/option_parser.py@274 PS19, Line 274: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/option_parser.py@386 PS19, Line 386: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/option_parser.py@391 PS19, Line 391: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/shell_output.py File shell/impala_shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/shell_output.py@40 PS19, Line 40: t flake8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/shell_output.py@44 PS19, Line 44: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/shell_output.py@105 PS19, Line 105: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/shell_output.py@134 PS19, Line 134: u flake8: F821 undefined name 'unicode' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/shell_output.py@136 PS19, Line 136: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/value_converter.py File shell/impala_shell/value_converter.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/value_converter.py@26 PS19, Line 26: v flake8: U100 Unused argument 'value' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/impala_shell/value_converter.py@29 PS19, Line 29: f flake8: U100 Unused argument 'format_specification' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py File shell/setup.py: http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py@97 PS19, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py@97 PS19, Line 97: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py@97 PS19, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py@97 PS19, Line 97: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py@97 PS19, Line 97: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/22330/19/shell/setup.py@105 PS19, Line 105: \ flake8: W605 invalid escape sequence '\d' -- To view, visit http://gerrit.cloudera.org:8080/22330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica75a24fa6bcb78999b9b6f4f4356951b81c3124 Gerrit-Change-Number: 22330 Gerrit-PatchSet: 19 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 20 May 2025 16:02:41 +0000 Gerrit-HasComments: Yes
