Surya Hebbar has posted comments on this change. (
http://gerrit.cloudera.org:8080/22857 )
Change subject: IMPALA-14032: Fix broken query timeline after webUI refactor in
IMPALA-13389
......................................................................
Patch Set 4:
Thank you for the quick response.
The tests in tests/webserver/test_web_pages.py are related to representation.
Any .tmpl or webpage changes will make changes to representation, so python
tests or others will be necessary, or maybe so in future.
But, .js files in www/ are unrelated to this.
I hope the following lines in the script, I have implemented to restrict to .js
files is sufficient. I have just verified this.
js_files=$(git diff ${PREV_HEAD} FETCH_HEAD --name-only | grep ^www | grep .js$
| wc -l)
all_files=$(git diff ${PREV_HEAD} FETCH_HEAD --name-only | wc -l)
if [[ "$js_files" != "$all_files" ]]
then
# message to gerrit - Use to verify only .js changes.
fi
--
To view, visit http://gerrit.cloudera.org:8080/22857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49a3e5405588edd07836605bff2efc00b9fa3ee9
Gerrit-Change-Number: 22857
Gerrit-PatchSet: 4
Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 May 2025 18:25:52 +0000
Gerrit-HasComments: No
