Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22857 )
Change subject: IMPALA-14032: Fix broken query timeline after webUI refactor in IMPALA-13389 ...................................................................... Patch Set 4: > Patch Set 3: > > That job can fail and avoid running tests if there are non-javascript files. > The alternative is that it still runs but won't give +1 verified if there are > non-javascript files. I'm ok with either. I wonder if tests/webserver/test_web_pages.py will overlap with JS test in one way or another. -- To view, visit http://gerrit.cloudera.org:8080/22857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49a3e5405588edd07836605bff2efc00b9fa3ee9 Gerrit-Change-Number: 22857 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 17:44:21 +0000 Gerrit-HasComments: No