Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22857 )
Change subject: IMPALA-14032: Fix broken query timeline after webUI refactor in IMPALA-13389 ...................................................................... Patch Set 4: (110 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@26 PS4, Line 26: import {showTooltip, hideTooltip} from "./chart_commons.js" Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@34 PS4, Line 34: const stroke_fill_colors = { black : "#000000", dark_grey : "#505050", There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@35 PS4, Line 35: light_grey : "#F0F0F0", transperent : "rgba(0, 0, 0, 0)" }; There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@47 PS4, Line 47: { color: "#C0C0FF", label: "Prepare" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@47 PS4, Line 47: { color: "#C0C0FF", label: "Prepare" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@47 PS4, Line 47: { color: "#C0C0FF", label: "Prepare" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@47 PS4, Line 47: { color: "#C0C0FF", label: "Prepare" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@48 PS4, Line 48: { color: "#E0E0E0", label: "Open" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@48 PS4, Line 48: { color: "#E0E0E0", label: "Open" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@48 PS4, Line 48: { color: "#E0E0E0", label: "Open" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@48 PS4, Line 48: { color: "#E0E0E0", label: "Open" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@49 PS4, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@49 PS4, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@49 PS4, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@49 PS4, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@50 PS4, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@50 PS4, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@50 PS4, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@50 PS4, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@51 PS4, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@51 PS4, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@51 PS4, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@51 PS4, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@52 PS4, Line 52: { color: "#FFC0C0", label: "Close" } There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@52 PS4, Line 52: { color: "#FFC0C0", label: "Close" } Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@52 PS4, Line 52: { color: "#FFC0C0", label: "Close" } Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@52 PS4, Line 52: { color: "#FFC0C0", label: "Close" } There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@161 PS4, Line 161: k = ((ts - min) * BUCKET_SIZE / EVENT_SPAN_T) | 0; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@186 PS4, Line 186: function DrawBars(svg, rownum, row_height, events, xoffset, px_per_ns) { 'rownum' is already declared in the upper scope on line 41 column 5. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@202 PS4, Line 202: let plan_node = getSvgGroup(); 'plan_node' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@214 PS4, Line 214: events.map((ev) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@227 PS4, Line 227: for (let i = LAST_E_INDEX; i >= 0; --i) { 'i' is already declared in the upper scope on line 219 column 7. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@237 PS4, Line 237: dy = (part.count / events[i].ts_list.length) * BAR_HEIGHT; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@297 PS4, Line 297: phases.forEach((p) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@305 PS4, Line 305: phases_header.appendChild(getSvgText(p.label, stroke_fill_colors.black, x + PHASE_WIDTH This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@323 PS4, Line 323: let pending_fragments = []; 'pending_fragments' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@324 PS4, Line 324: let fevents = fragment.events; 'fevents' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@326 PS4, Line 326: let frag_name = fragment.name.replace("Coordinator ", "").replace("Fragment ", ""); 'frag_name' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@332 PS4, Line 332: let fragment_svg_group = getSvgGroup(); 'fragment_svg_group' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@336 PS4, Line 336: let node = fragment.nodes[i]; 'node' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@362 PS4, Line 362: let label_x = frag_name_width + CHAR_WIDTH * pending_children; 'label_x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@363 PS4, Line 363: let label_width = Math.min(CHAR_WIDTH * node.name.length, 'label_width' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@369 PS4, Line 369: let y = ROW_HEIGHT * node.parent_node.rendering.rownum; 'y' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@371 PS4, Line 371: let x = name_width + Math.min.apply(null, fevents[3].ts_list) * PX_PER_NS; 'x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@377 PS4, Line 377: let x2 = name_width + Math.max.apply(null, fevents[4].ts_list) * PX_PER_NS; 'x2' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@384 PS4, Line 384: let x = name_width - (pending_senders) * CHAR_WIDTH - CHAR_WIDTH / 2; 'x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@384 PS4, Line 384: let x = name_width - (pending_senders) * CHAR_WIDTH - CHAR_WIDTH / 2; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@396 PS4, Line 396: let x = frag_name_width + (pending_children + 1) * CHAR_WIDTH - 'x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@402 PS4, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@402 PS4, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; Missing space after key 'rownum'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@402 PS4, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; Missing space after key 'label_end'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@402 PS4, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@405 PS4, Line 405: pending_children += (node.num_children - node.is_receiver); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@412 PS4, Line 412: printFragment(fragments[node.sender_frag_index]) Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@419 PS4, Line 419: fragment_svg_group.addEventListener('click', updateFragmentMetricsChartOnClick); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@425 PS4, Line 425: fragments.forEach((fragment) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@432 PS4, Line 432: let sec_per_tic = maxts / ntics / 1e9; 'sec_per_tic' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@433 PS4, Line 433: let px_per_tic = chart_width / ntics; 'px_per_tic' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@435 PS4, Line 435: let y = 0; 'y' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@436 PS4, Line 436: let text_y = ROW_HEIGHT - 4; 'text_y' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@464 PS4, Line 464: execution_profile.child_profiles.forEach((fp) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@481 PS4, Line 481: if (fp.child_profiles[instance].event_sequences[0].events.length == Expected '===' and instead saw '=='. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@508 PS4, Line 508: name: fp.profile_name, Missing space after key 'name'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@509 PS4, Line 509: events: fevents, Missing space after key 'events'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@510 PS4, Line 510: nodes: [ ], Missing space after key 'nodes'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@511 PS4, Line 511: color: fragment_colors[color_idx] Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@512 PS4, Line 512: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@524 PS4, Line 524: let name_flds = pp.profile_name.split(/[()]/); 'name_flds' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@526 PS4, Line 526: let node_type = name_flds[0].trim(); 'node_type' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@528 PS4, Line 528: let node_id = name_flds.length > 1 ? 'node_id' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@536 PS4, Line 536: let table_name = pp.info_strings.find(({ key }) => key === "Table Name") 'table_name' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@536 PS4, Line 536: let table_name = pp.info_strings.find(({ key }) => key === "Table Name") There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@536 PS4, Line 536: let table_name = pp.info_strings.find(({ key }) => key === "Table Name") There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@543 PS4, Line 543: (node_type === "HASH_JOIN_NODE" && pp.num_children < 3); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@545 PS4, Line 545: const IS_SENDER = (node_type === "Hash Join Builder" || Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@576 PS4, Line 576: name: node_name, Missing space after key 'name'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@577 PS4, Line 577: type: node_type, Missing space after key 'type'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@578 PS4, Line 578: node_id: node_id, Missing space after key 'node_id'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@579 PS4, Line 579: num_children: 0, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@580 PS4, Line 580: child_index: 0, Missing space after key 'child_index'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@581 PS4, Line 581: metadata: pp.node_metadata, Missing space after key 'metadata'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@582 PS4, Line 582: parent_node: parent_node, Missing space after key 'parent_node'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@583 PS4, Line 583: events: node_events, Missing space after key 'events'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@584 PS4, Line 584: path: node_path.slice(0), Missing space after key 'path'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@585 PS4, Line 585: is_receiver: IS_RECEIVER, Missing space after key 'is_receiver'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@586 PS4, Line 586: is_sender: IS_SENDER Missing space after key 'is_sender'. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@587 PS4, Line 587: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@632 PS4, Line 632: node.events[en].ts_list.push(cp.event_sequences[0].events[en].timestamp); This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@636 PS4, Line 636: while(i < node.events.length && en < cp.event_sequences[0].events.length) { This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@638 PS4, Line 638: node.events[i].ts_list.push(cp.event_sequences[0].events[en].timestamp); This line has a length of 92. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@661 PS4, Line 661: export function setTimingDiagramDimensions(ignored_arg) { 'ignored_arg' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@697 PS4, Line 697: fragment_diagram.addEventListener('mouseout', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@697 PS4, Line 697: fragment_diagram.addEventListener('mouseout', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@697 PS4, Line 697: fragment_diagram.addEventListener('mouseout', (e) => { 'e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@703 PS4, Line 703: fragment_diagram.addEventListener('mousemove', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@703 PS4, Line 703: fragment_diagram.addEventListener('mousemove', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@704 PS4, Line 704: if (e.clientX + scrollable_screen.scrollLeft >= name_width && e.clientX + scrollable_screen.scrollLeft <= name_width + chart_width){ This line has a length of 134. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@704 PS4, Line 704: if (e.clientX + scrollable_screen.scrollLeft >= name_width && e.clientX + scrollable_screen.scrollLeft <= name_width + chart_width){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@706 PS4, Line 706: timestamp_gridline = getSvgLine(stroke_fill_colors.black, e.clientX + scrollable_screen.scrollLeft, 0, e.clientX + scrollable_screen.scrollLeft, This line has a length of 148. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@709 PS4, Line 709: const GRIDLINE_TIME = ((maxts * (e.clientX + scrollable_screen.scrollLeft - name_width) / chart_width) / 1e9); This line has a length of 114. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@709 PS4, Line 709: const GRIDLINE_TIME = ((maxts * (e.clientX + scrollable_screen.scrollLeft - name_width) / chart_width) / 1e9); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@709 PS4, Line 709: const GRIDLINE_TIME = ((maxts * (e.clientX + scrollable_screen.scrollLeft - name_width) / chart_width) / 1e9); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@716 PS4, Line 716: } catch (e) { 'e' is already declared in the upper scope on line 703 column 49. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@723 PS4, Line 723: fragment_diagram.addEventListener('wheel', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@723 PS4, Line 723: fragment_diagram.addEventListener('wheel', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@747 PS4, Line 747: timeticks_footer.addEventListener('wheel', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@747 PS4, Line 747: timeticks_footer.addEventListener('wheel', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@755 PS4, Line 755: const RENDERING_CONSTRAINT = CHAR_WIDTH * ((decimals + 1) + INTEGER_PART_ESTIMATE) Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@774 PS4, Line 774: plan_order.addEventListener('click', renderFragmentDiagram); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22857/4/www/scripts/query_timeline/fragment_diagram.js@776 PS4, Line 776: if (typeof process !== "undefined" && process.env.NODE_ENV === 'test') { Strings must use doublequote. -- To view, visit http://gerrit.cloudera.org:8080/22857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49a3e5405588edd07836605bff2efc00b9fa3ee9 Gerrit-Change-Number: 22857 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 17:38:58 +0000 Gerrit-HasComments: Yes
