Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22853 )
Change subject: IMPALA-14028: Refactor cancel_query_and_validate_state with HS2 ...................................................................... IMPALA-14028: Refactor cancel_query_and_validate_state with HS2 cancel_query_and_validate_state is a helper method used to test query cancellation with concurrent fetch. It is still use beeswax client by default. This patch change the test method to use HS2 protocol by default. The changes include following: 1. Set TGetOperationStatusResp.operationState to TOperationState::ERROR_STATE if returning abnormally. 2. Use separate MinimalHS2Client for (execute_async, fetch, get_runtime_profile) vs cancel vs close. Cancellation through KILL QUERY still instantiate new ImpylaHS2Connection client. 3. Implement required missing methods in MinimalHS2Client. 4. Change MinimalHS2Client logging pattern to match with other clients. Testing: Pass test_cancellation.py and TestResultSpoolingCancellation in core exploration mode. Also fix default_test_protocol to HS2 for these tests. Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984 Reviewed-on: http://gerrit.cloudera.org:8080/22853 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Riza Suminto <riza.sumi...@cloudera.com> --- M be/src/service/impala-hs2-server.cc M tests/common/impala_connection.py M tests/query_test/test_cancellation.py M tests/query_test/test_result_spooling.py M tests/util/cancel_util.py 5 files changed, 235 insertions(+), 90 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Riza Suminto: Verified -- To view, visit http://gerrit.cloudera.org:8080/22853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984 Gerrit-Change-Number: 22853 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com>
