Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22734/6/tests/query_test/test_debug_action.py File tests/query_test/test_debug_action.py: http://gerrit.cloudera.org:8080/#/c/22734/6/tests/query_test/test_debug_action.py@84 PS6, Line 84: @classmethod : def add_test_dimensions(cls): : super(TestDebugAction, cl > nit: This can be removed. Ack http://gerrit.cloudera.org:8080/#/c/22734/6/tests/query_test/test_debug_action.py@95 PS6, Line 95: self.client, self._query, vector.get_value('exec_option')) : assert self._debug_actions[vector.get_value('debug_action')] in str(result) : : : > You can replace this with a fixed table_format dimension. Ack -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Apr 2025 12:09:08 +0000 Gerrit-HasComments: Yes
