Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/22734/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22734/8//COMMIT_MSG@25 PS8, Line 25: consist > nit. Not sure what "sparsed" means here, using a simpler word might help ma Ack http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/exec/exec-node.cc@476 PS8, Line 476: if (!param.empty()) { > Maybe better adding DCHECK(sleep_duration_ms != nullptr) Yes, why not. http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/service/query-options.cc@316 PS8, Line 316: // Verify General DebugAction's first. In case it's valid proceed to : // ExecNode verification. 'invali > Maybe clarify this comment a bit. Like, "Verify General DebugAction's first Ack, hope made it more clear. -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 10 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 25 Apr 2025 10:22:55 +0000 Gerrit-HasComments: Yes
