Csaba Ringhofer has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/22780 )

Change subject: IMPALA-13746: Fix long ldap password handling in 
impala-shell+hs2-http
......................................................................

IMPALA-13746: Fix long ldap password handling in impala-shell+hs2-http

Before this patch impala-shell inserted a \n char after every 76 bytes.
The fix is to switch to a different function for encoding. The exact
semantics of base64 functions is described in
https://docs.python.org/3/library/base64.html

Based on impyla fix https://github.com/cloudera/impyla/pull/562 by
https://github.com/paulmayer (released in Impyla 0.21a3)

Change-Id: I4d73d682cf2d1843d9801ef71b99d551b79deb19
Reviewed-on: http://gerrit.cloudera.org:8080/22780
Reviewed-by: Csaba Ringhofer <csringho...@cloudera.com>
Tested-by: Csaba Ringhofer <csringho...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/testutil/LdapUtil.java
M fe/src/test/resources/users.ldif
M shell/impala_client.py
4 files changed, 31 insertions(+), 6 deletions(-)

Approvals:
  Csaba Ringhofer: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/22780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d73d682cf2d1843d9801ef71b99d551b79deb19
Gerrit-Change-Number: 22780
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>

Reply via email to