Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22780 )
Change subject: IMPALA-13746: Fix long ldap password handling in impala-shell+hs2-http ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/22780/1/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java File fe/src/test/java/org/apache/impala/testutil/LdapUtil.java: http://gerrit.cloudera.org:8080/#/c/22780/1/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java@44 PS1, Line 44: public static final String TEST_PASSWORD_LONG = : "verylongpasswordthatcreatesalongbasic64encoding" > I don't know if there is a maximum length. The current password is enough t Ack http://gerrit.cloudera.org:8080/#/c/22780/3/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java File fe/src/test/java/org/apache/impala/testutil/LdapUtil.java: http://gerrit.cloudera.org:8080/#/c/22780/3/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java@45 PS3, Line 45: verylongpasswordthatcreatesalongbasic64encoding nit: consider documenting the encoded value for this long password somewhere. But don't worry about it if dryrun test passed. -- To view, visit http://gerrit.cloudera.org:8080/22780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d73d682cf2d1843d9801ef71b99d551b79deb19 Gerrit-Change-Number: 22780 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 15:16:16 +0000 Gerrit-HasComments: Yes
