Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22780 )
Change subject: IMPALA-13746: Fix long ldap password handling in impala-shell+hs2-http ...................................................................... Patch Set 6: Verified+1 Code-Review+2 (1 comment) only added a new comment, carrying +2 and GVO +1 http://gerrit.cloudera.org:8080/#/c/22780/3/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java File fe/src/test/java/org/apache/impala/testutil/LdapUtil.java: http://gerrit.cloudera.org:8080/#/c/22780/3/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java@45 PS3, Line 45: verylongpasswordthatcreatesalongbasic64encoding > nit: consider documenting the encoded value for this long password somewher added a comment with the length of the encoded value -- To view, visit http://gerrit.cloudera.org:8080/22780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d73d682cf2d1843d9801ef71b99d551b79deb19 Gerrit-Change-Number: 22780 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 06:17:41 +0000 Gerrit-HasComments: Yes
