Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22571 )
Change subject: IMPALA-13684: Improve waitForHmsEvent() to only wait for related events ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/22571/12/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22571/12/tests/custom_cluster/test_events_custom_configs.py@1624 PS12, Line 1624: catalogd_args="--debug_actions=catalogd_event_processing_delay:SLEEP@200") : def test_hms_event_sync_with_commit_compaction(self, vector, un > No special args for this CustomClusterTest. Good point! http://gerrit.cloudera.org:8080/#/c/22571/12/tests/custom_cluster/test_events_custom_configs.py@1638 PS12, Line 1638: execute_query_expect_succes > specify protocol based on given vector. Done http://gerrit.cloudera.org:8080/#/c/22571/12/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/22571/12/tests/metadata/test_event_processing.py@414 PS12, Line 414: self.run_stmt_in_hive( : "insert overwrite table {0} partition (p=0) select > nit: We can shorten it like this: Done -- To view, visit http://gerrit.cloudera.org:8080/22571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic033b7e197cd19505653c3ff80c4857cc474bcfc Gerrit-Change-Number: 22571 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 01:47:01 +0000 Gerrit-HasComments: Yes
