Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22571 )
Change subject: IMPALA-13684: Improve waitForHmsEvent() to only wait for related events ...................................................................... Patch Set 12: Code-Review+1 (3 comments) Looks good. I just have some nits. http://gerrit.cloudera.org:8080/#/c/22571/12/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22571/12/tests/custom_cluster/test_events_custom_configs.py@1624 PS12, Line 1624: @CustomClusterTestSuite.with_args() : def test_event_processor_pauses(self, vector, unique_database): No special args for this CustomClusterTest. This can be a regular E2E test with @pytest.mark.execute_serially. http://gerrit.cloudera.org:8080/#/c/22571/12/tests/custom_cluster/test_events_custom_configs.py@1638 PS12, Line 1638: self.create_impala_client() specify protocol based on given vector. http://gerrit.cloudera.org:8080/#/c/22571/12/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/22571/12/tests/metadata/test_event_processing.py@414 PS12, Line 414: client = self.default_impala_client(vector.get_value('protocol')) : client.set_configuration(vector.get_exec_option_dict()) nit: We can shorten it like this: client = self.create_impala_client_from_vector(vector) -- To view, visit http://gerrit.cloudera.org:8080/22571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic033b7e197cd19505653c3ff80c4857cc474bcfc Gerrit-Change-Number: 22571 Gerrit-PatchSet: 12 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 21:23:05 +0000 Gerrit-HasComments: Yes
